[BUG]Login rejection

[MON1TOR]

If I try to login with a password (a valid one) wich contains special chars,
like $ - or . and press the 'login' button, a dialog with the text
'Please select a profile and enter the password for it.' or smthng like that shows up. I needed to change my pwd, now it works fine. Any ideas?

[xrichardx]

The $ symbol is reserved to access cvars, that causes trouble here. The Login button just executes

Code: [Select]

profile_login $menu_profile_file $menu_profile_pass

where menu_profile_file and menu_profile_pass are cvars you can set above by selecting the profile and typing in a password. The variable names will just be replaced with what these vars contain before executing the command. If your variable contains any reserved special chars (I think the dollar sign ($) and quotation mark (") are the only reserved ASCII chars), this will cause trouble because the game thinks you want to use these with their special meaning altough you want them as plaintext.
For example:

Code: [Select]

menu_profile_file MyAccount
menu_profile_pass $MyPass

profile_login $menu_profile_file $menu_profile_pass
will evaluate to
profile_login MyAccount $MyPass

$MyPass is not set here since you never intended it to be a variable. You can go around that by typing in your password in quotation marks ("). This would result in:

Code: [Select]

menu_profile_file MyAccount
menu_profile_pass "$MyPass"

profile_login $menu_profile_file $menu_profile_pass
will evaluate to
profile_login MyAccount "$MyPass"

Here, the game parses $MyPass as plaintext and does not give an error.

[MON1TOR]

Okay, I understand. Thanks! jitspoe, you should add a password field validator to prevent ppl from changing pwds to a pwd with the $ symbol....

[jitspoe]

Thanks for bringing this to my attention.  I'd like to make all special characters allowable.  I wasn't aware there was an issue with $'s.

[MON1TOR]

Thanks for bringing this to my attention.  I'd like to make all special characters allowable.  I wasn't aware there was an issue with $'s.

It's okay. I prefer strong passwords, so that would be great
If you could make $s work. In pwds.

[jitspoe]

Added to the feature vote so I don't lose track of it:

http://dplogin.com/dplogin/featurevote/feature.php?id=10313

[MON1TOR]

Thanks.